8000 T131 — Skip and name each export that cannot be copied, and end a successful command with exit 125 · Issue #3445 · gominimal/minimal · GitHub
[go: up one dir, main page]

Skip to content

T131 — Skip and name each export that cannot be copied, and end a successful command with exit 125 #3445

Closed

Description

@agent-137

Task

slice size difficulty model who estimated lines
Tasks leave exited boxes M needs care strongest an agent 400 (170 code, 230 tests)

An export whose source is missing, whose copy fails, or whose destination or source leads out of the project or out of /workbench through a symlink is skipped and named on stderr, and the other exports still copy. A skipped export ends a successful command with exit 125. Every other exit code stands.

Covers:

  • BOX-190
  • BOX-191
  • BOX-193
  • BOX-194

BOX-192 and BOX-196 moved to T134 (#3453) on 2026-11-15, after arch ruling 1313 on #3448. The T130 pull request, #3448, delivers it. Their checks, messages and tests are T134's.

Layers:

  • client:
    • crates/minimal/src/cmd/boxes/exports.rs: skip and name each failing export; a partly written export counts as skipped
    • crates/minimal/src/task.rs: exit 125 in place of 0 when an export is skipped; other codes stand
    • crates/minimal/src/cmd/boxes/attach.rs: the same for an attach
    • crates/minimal/src/cmd/boxes/wait.rs: the same for min box wait
    • crates/minimal/src/tests.rs: tests
    • cargo nextest run -p minimal missing_export_named_and_others_copied
    • cargo nextest run -p minimal failed_export_file_leaves_its_destination_unchanged
    • cargo nextest run -p minimal skipped_export_exit125_when_task_succeeded
    • cargo nextest run -p minimal skipped_export_keeps_failed_task_exit_code

User-facing text. One stderr line per skipped export, each naming the export's path:

  • Export <path> was not copied: it was not found in the box. (BOX-190)
  • Export <path> was not copied: <reason the system gave>. (BOX-191)

The tests above pin each line.

Owner decisions this task follows:

Plan block
### T131 — Skip and name each export that cannot be copied, and end a successful command with exit 125
  slice: S2
  kind: task
  covers: BOX-190, BOX-191, BOX-193, BOX-194
  size: M
  est: 170 code, 230 tests
  executor: agent
  difficulty: needs care
  model: strongest
  diagnostics: each skipped or refused export is named on stderr with its path
  observability: the box's record carries a file_exported event for each export
  layers:
    - client:
      - crates/minimal/src/cmd/boxes/exports.rs: skip and name each failing export; a partly written export counts as skipped
      - crates/minimal/src/task.rs: exit 125 in place of 0 when an export is skipped; other codes stand
      - crates/minimal/src/cmd/boxes/attach.rs: the same for an attach
      - crates/minimal/src/cmd/boxes/wait.rs: the same for `min box wait`
      - crates/minimal/src/tests.rs: tests
      test: cargo nextest run -p minimal missing_export_named_and_others_copied
      test: cargo nextest run -p minimal failed_export_file_leaves_its_destination_unchanged
      test: cargo nextest run -p minimal skipped_export_exit125_when_task_succeeded
      test: cargo nextest run -p minimal skipped_export_keeps_failed_task_exit_code
  produces: none
  consumes: 
    - crates/minimal/src/cmd/boxes/exports.rs
  proof: a task whose export is missing, one whose destination is a symlink out of the project, and one whose source leaves /workbench each name the export, copy the rest, and exit 125; a task that timed out still exits 124.
  depends on:
    - blocked by #3444

Activity

  1. minimal-foundry commented on Nov 16, 2026

    @minimal-foundry
    Contributor

    Done. #3487 merged.

    branch agent/3445-skip-and-name-each-export-that-cannot-be-copied · epic #2236 · PR #3487

    round outcome job
    1 pushed 05578dc8
    2 pushed 37ad2a32
    3 pushed d7896ff2

    Updated 2026-11-17T04:05:51.694Z.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions

      0