8000 T129 — Refuse a TPM key the proxy cannot load, and keep a key that may come back · Issue #3326 · gominimal/minimal · GitHub
[go: up one dir, main page]

Skip to content

T129 — Refuse a TPM key the proxy cannot load, and keep a key that may come back #3326

Closed

Description

@norrietaylor

Task

slice size difficulty model who estimated lines
Linux hosts hold the proxy's keys M needs care standard an agent 420 (180 code, 240 tests)

A proxy whose TPM is unreachable, busy or whose key file it cannot read refuses to start and keeps the key, and one whose key is gone refuses and names bep --replace-key for that role.

Covers:

  • BEP-089

Layers:

  • store:
    • crates/bep/src/tpm.rs: sorts a failed load into kept (the TPM cannot be reached, or answers with a temporary response such as TPM_RC_OBJECT_MEMORY or TPM_RC_RETRY, or a file this user cannot read) and lost (a missing key or authorization file, or an integrity or hierarchy error on the key file), as a KeyError that names the role and the case
    • crates/bep/src/keys.rs: StartError carries the kept and lost TPM cases, and its Display prints the four refusals above
    • cargo nextest run -p bep an_unreachable_tpm_refuses_start_and_keeps_the_key
    • cargo nextest run -p bep a_tpm_key_the_tpm_cannot_load_refuses_start
    • cargo nextest run -p bep an_unreadable_tpm_key_file_refuses_start_and_keeps_the_key

Waits on:

Plan block
### T129 — Refuse a TPM key the proxy cannot load, and keep a key that may come back
  slice: S18
  kind: task
  covers: BEP-089
  size: M
  est: 180 code, 240 tests
  executor: agent
  difficulty: needs care
  model: standard
  diagnostics: each refusal prints to the person who started `bep`, pinned by its test: "The proxy did not start: the TPM cannot load the proxy's <role> key now (<the TPM's response>). The key is kept; start the proxy again when the TPM is available." for an unreachable TPM or a temporary response; "The proxy did not start: this user cannot read <path>, which holds the proxy's <role> key. The key is kept." for an unreadable file; "The proxy did not start: <the key file|the authorization file> of the proxy's <role> key is missing: <path>. Run `bep --replace-key <role>` to make a new one. Boxes created before then must be re-created." for a missing file; and "The proxy did not start: this TPM no longer holds the proxy's <role> key. Run `bep --replace-key <role>` to make a new one. Boxes created before then must be re-created." for a key file the TPM refuses as not its own
  observability: each refusal also logs one error line with the role, `store=tpm`, the TPM's response code and whether the key is kept or lost
  layers:
    - store:
      - crates/bep/src/tpm.rs: sorts a failed load into kept (the TPM cannot be reached, or answers with a temporary response such as `TPM_RC_OBJECT_MEMORY` or `TPM_RC_RETRY`, or a file this user cannot read) and lost (a missing key or authorization file, or an integrity or hierarchy error on the key file), as a `KeyError` that names the role and the case
      - crates/bep/src/keys.rs: `StartError` carries the kept and lost TPM cases, and its `Display` prints the four refusals above
      test: cargo nextest run -p bep an_unreachable_tpm_refuses_start_and_keeps_the_key
      test: cargo nextest run -p bep a_tpm_key_the_tpm_cannot_load_refuses_start
      test: cargo nextest run -p bep an_unreadable_tpm_key_file_refuses_start_and_keeps_the_key
  produces: none
  consumes:
    - crates/bep/src/tpm.rs
  proof: A proxy whose TPM is unreachable, busy or whose key file it cannot read refuses to start and keeps the key, and one whose key is gone refuses and names `bep --replace-key` for that role.
  depends on:
    - blocked by #3324

Activity

  1. added
    kind:taskA task the plan skill rendered; the body carries ## Task
    size:M200 to 500 net lines; one PR
    model:standardA standard model: work that needs care, or routine work that is large
    on Nov 12, 2026
  2. minimal-foundry commented on Nov 13, 2026

    @minimal-foundry
    Contributor

    Done. #3412 merged.

    branch agent/3326-refuse-a-tpm-key-the-proxy-cannot-load-and-keep · epic #1501 · PR #3412

    round outcome job
    1 pushed 01e44d52
    2 pushed d0818726

    Updated 2026-11-14T03:15:04.970Z.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    kind:taskA task the plan skill rendered; the body carries ## Taskmodel:standardA standard model: work that needs care, or routine work that is largesize:M200 to 500 net lines; one PR

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions

      0