8000 Tracing spans record source URLs with credentials (remote_storage download_web*) · Issue #2817 · gominimal/minimal · GitHub
[go: up one dir, main page]

Skip to content

Tracing spans record source URLs with credentials (remote_storage download_web*) #2817

Open

Description

@norrietaylor

Follow-up from the review of #2795 (T124).

#[tracing::instrument] on RemoteStorage::download_web_placed and on RemoteStorage::download_web_with_verification_and_caching (crates/common/src/remote_storage.rs) records the url argument in the span. A source URL can carry user:password@ and a signed query token. Any subscriber that records span fields, such as an OTLP exporter or a JSON log, then stores the secret. The log lines in crates/op/src/sources.rs already strip URLs for this reason (strip_urls, stripped_url).

What to do

  • Add skip(url) to both attributes, and record a stripped URL as a span field instead (fields(url = %stripped_url(url))).
  • Check the other #[tracing::instrument] attributes in crates/common and crates/op that take a URL.

This is a residual of epic #1437 (NET).

Activity

  1. added
    kind:taskA task the plan skill rendered; the body carries ## Task
    on Oct 31, 2026
  2. norrietaylor commented on Nov 20, 2026

    @norrietaylor
    MemberAuthor

    Task

    Source: #2817

    Plan block
    ### D2817 — The download_web spans of RemoteStorage record the source URL with no credentials, no query and no fragment
      kind: task
      size: S
      est: 25 code, 70 tests
      executor: agent
      origin: residual
      epic: 1437
      layers:
        - spans:
          - crates/common/src/remote_storage.rs: Add skip(url) to the instrument attributes of download_web_with_verification_and_caching and download_web_placed, and record fields(url) from the stripped URL. Add a pub stripped_url function and a test that reads the span fields.
          - crates/common/src/lib.rs: Export stripped_url from remote_storage.
          - crates/op/src/specs.rs: stripped_url calls common::stripped_url, so one function strips a URL. strip_urls and its callers in sources.rs stay as they are.
          test: cargo test -p common download_web_spans_record_a_stripped_url
      proof: A subscriber that records span fields shows https://host/path for a source URL that carries user:password@ and a signed query, and the password and the token are not in the span.
    
  3. norrietaylor commented on Nov 20, 2026

    @norrietaylor
    MemberAuthor

    /implement

  4. minimal-foundry commented on Nov 20, 2026

    @minimal-foundry
    Contributor

    Pull request #3713 is open for D2817.

    branch agent/2817-the-download-web-spans-of-remotestorage-record-t · epic #1437

    test exit tail
    cargo test -p common download_web_spans_record_a_stripped_url 0 running 1 test test remote_storage::span_tests::download_web_spans_record_a_stripped_url ... ok test result: ok. 1 passed; 0 failed; 0 ignored; 0 measured; 91 filtered out; finished in 0.12s running 0 tests test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 1 filtered out; finished in

    Verify min task run agent-verify: exit 100 — FAIL [ 90.434s] (159/159) common::shell_harnesses all_script_test_harnesses_pass thread 'all_script_test_harnesses_pass' (2526) panicked at crates/common/tests/shell_harnesses.rs:83:5: shell test harnesses failed: metrics_test.sh failed (exit status: 1): == snapshot_validate

    Updated 2026-11-20T22:51:12.148Z.

  5. minimal-foundry commented on Nov 20, 2026

    @minimal-foundry
    Contributor

    That /implement is held, not dropped. The container platform had no instance to give the coder: its pool of prepared containers was full, which happens most just after a deploy. It is asked again every 10 minutes for up to 30.

    Nothing to type again: the command gets a rocket when its coder starts, or a refusal that names the reason.

    What the platform said

    could not start the coder: Error: there is no container instance that can be provided to this durable object

  6. minimal-foundry commented on Nov 20, 2026

    @minimal-foundry
    Contributor

    That /implement is queued, not refused. 10 follow-up coders are in flight, and 10 is the most that run at once, so no coder started. 1 queued command is ahead of it. The runtime starts queued follow-up coders oldest first as room frees, looking every ten minutes, and refuses one still waiting after 14 days.

    Nothing to type again: the command gets a rocket when its coder starts, or a refusal that names the reason. /implement stop takes it off the queue.

  7. minimal-foundry commented on Nov 20, 2026

    @minimal-foundry
    Contributor

    That /implement is held, not dropped. The container platform had no instance to give the coder: its pool of prepared containers was full, which happens most just after a deploy. It is asked again every 10 minutes for up to 30.

    Nothing to type again: the command gets a rocket when its coder starts, or a refusal that names the reason.

    What the platform said

    could not start the coder: Error: there is no container instance that can be provided to this durable object

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    kind:taskA task the plan skill rendered; the body carries ## Taskpriority:should-haveShould be done. Applied by the inbox-route classifier or a human.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions

      0