8000 T23 — Check type constraints last, and let a derived type only narrow · Issue #2424 · gominimal/minimal · GitHub
[go: up one dir, main page]

Skip to content

T23 — Check type constraints last, and let a derived type only narrow #2424

Closed

Description

@mitodrummer

Task

slice size difficulty model who estimated lines
Types only narrow L needs care strongest an agent 540 (300 code, 240 tests)

An entry breaking its type's constraint fails naming the layer.

Covers:

  • BOX-061
  • BOX-062
  • BOX-156

Layers:

  • constraints:
    • crates/mfile/src/box_types.rs: narrowing only; never adds
    • crates/mfile/src/expand.rs: constraints checked last
    • cargo nextest run -p mfile expanded_spec_violating_constraint_exit3_names_type_and_layer
    • cargo nextest run -p mfile derived_type_loosening_constraint_exit3_names_type_key_parent
    • cargo nextest run -p mfile constraint_never_adds_package_port_or_egress

Waits on:

Plan block
### T23 — Check type constraints last, and let a derived type only narrow
  slice: S5
  kind: task
  covers: BOX-061, BOX-062, BOX-156
  size: L
  est: 300 code, 240 tests
  executor: agent
  difficulty: needs care
  model: strongest
  diagnostics: error names type, key and layer
  observability: none: a pure function, no runtime
  layers:
    - constraints:
      - crates/mfile/src/box_types.rs: narrowing only; never adds
      - crates/mfile/src/expand.rs: constraints checked last
      test: cargo nextest run -p mfile expanded_spec_violating_constraint_exit3_names_type_and_layer
      test: cargo nextest run -p mfile derived_type_loosening_constraint_exit3_names_type_key_parent
      test: cargo nextest run -p mfile constraint_never_adds_package_port_or_egress
  produces: none
  consumes:
    - crates/mfile/src/box_types.rs
  proof: An entry breaking its type's constraint fails naming the layer.
  depends on:
    - blocked by #2420

Activity

  1. added
    kind:taskA task the plan skill rendered; the body carries ## Task
    size:L500 to 900 net lines; one PR, and the ceiling
    model:strongestThe strongest model available: unknown ground, or large work that needs care
    on Oct 19, 2026
  2. minimal-foundry commented on Nov 11, 2026

    @minimal-foundry
    Contributor

    Done. #3292 merged.

    branch agent/2424-check-type-constraints-last-and-let-a-derived-ty · epic #2236 · PR #3292

    round outcome job
    1 pushed c167c0de
    2 pushed 5f1fb3f9
    3 changed nothing: Residual of T23: #3295 . No product path calls mfile::expand::check_constraints yet. The expand calls in crates/minimal/src/cmd/boxes/create.rs (lines 1345 a 326023ad
    4 pushed bc705910
    5 pushed a469e857

    Updated 2026-11-12T06:37:18.771Z.

  3. norrietaylor commented on Nov 12, 2026

    @norrietaylor
    Member

    /implement

  4. added
    needs-humanAn agent handed off; a human must act, then clear this label. Set by defer and handoffs.
    on Nov 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    kind:taskA task the plan skill rendered; the body carries ## Taskmodel:strongestThe strongest model available: unknown ground, or large work that needs careneeds-humanAn agent handed off; a human must act, then clear this label. Set by defer and handoffs.size:L500 to 900 net lines; one PR, and the ceiling

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions

      0