8000 App/patches/howler/details.md at main · dominictb/App · GitHub
[go: up one dir, main page]

Skip to content

Latest commit

 

History

History
16 lines (12 loc) · 961 Bytes

details.md

File metadata and controls

16 lines (12 loc) · 961 Bytes

howler patches

  • Reason:

    Howler calls `AudioContext.resume()` in the audio unlock handler and in `_autoResume()` without handling a rejected promise.
    iOS Safari rejects it with `InvalidStateError: Failed to start the audio device` when it can't start the audio session
    (for example, during a phone call or while another app holds the audio session), which surfaces as an unhandled promise rejection.
    This patch adds no-op rejection handlers. Howler only sets its state to 'running' after a successful resume, so the next play() still retries.
    
  • Upstream PR/issue: goldfire/howler.js#1743, goldfire/howler.js#1764

  • E/App issue: Expensify#102744

  • PR introducing patch: Expensify#102795

0