You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Reviewer routing for read-only LDAP username validation fix (#53514)
#53753
Hi all — could someone point me to the appropriate reviewer for the username-validation / LDAP federation area?
I have a small fix in #53514 for #52215. It prevents an unchanged, case-preserved LDAP username from being rejected as a username mutation when the username is read-only. The change is limited to the validator and a regression test (two files, one commit).
The fork validation is linked from the PR; upstream workflows are awaiting maintainer approval. I would appreciate guidance on who owns this path, and whether any additional regression coverage is needed before review.
I understand the review queue is large — this is a routing question, not a request to bypass normal review. Happy to address feedback. Thanks!
reacted with thumbs up emoji reacted with thumbs down emoji reacted with laugh emoji reacted with hooray emoji reacted with confused emoji reacted with heart emoji reacted with rocket emoji reacted with eyes emoji
Uh oh!
There was an error while loading. Please reload this page.
Hi all — could someone point me to the appropriate reviewer for the username-validation / LDAP federation area?
I have a small fix in #53514 for #52215. It prevents an unchanged, case-preserved LDAP username from being rejected as a username mutation when the username is read-only. The change is limited to the validator and a regression test (two files, one commit).
The fork validation is linked from the PR; upstream workflows are awaiting maintainer approval. I would appreciate guidance on who owns this path, and whether any additional regression coverage is needed before review.
I understand the review queue is large — this is a routing question, not a request to bypass normal review. Happy to address feedback. Thanks!
All reactions