Repository navigation
fix(mfile): refuse legacy network spellings with exit 3 after the grace release #3120
Description
Residual of BOX T17 (#2411, PR #3105), from arch condition C1 (arch_rulings 1037), raised when #3105 merged main after #3106 (T19).
legacy reads the old tables for one release, 0.8, with a hint, and refuses them with exit 3 from 0.9.0 (legacy::past_grace). mfile::network::canonicalize from #3106 also rewrites old spellings: a legacy mode spelling (LEGACY_MODES, such as no-net) or a flat egress key (FLAT_EGRESS_KEYS). It gives one hint each, but it never refuses them, so the network spellings would outlive the grace that the legacy tables end at.
Scope:
network::canonicalizetakes the release, aslegacy::canonicalizedoes.- When
legacy::past_grace(release)is true, it returns an exit-3 error for a legacymodespelling or a flat egress key, carrying the same hint thatlegacy_mode_hintorflat_egress_hintgives. legacy_tables_exit3_after_grace_releaseasserts the refusal for one mode spelling and one flat key at0.9.0, and asserts that0.8.0-devaccepts both.
Related: #3116, the create-path caller of canonicalize.
Activity