8000 T97 — Accept source = "store" with store and id in a box spec's grant · Issue #2656 · gominimal/minimal · GitHub
[go: up one dir, main page]

Skip to content
< 8000 /div>

T97 — Accept source = "store" with store and id in a box spec's grant #2656

Closed

Description

@norrietaylor

Task

slice size difficulty model who estimated lines
Round-four residuals closed M needs care standard an agent 400 (160 code, 240 tests)

A box spec that declares a store reference as source = "store" with store and id mints and redeems it, and min box spec lists it with its authorities.

Covers:

  • BEP-032

Layers:

  • grant:
    • crates/boxes/src/core/bep.rs: GrantSource accepts source = "store" with store and id, and store_references() reads store references from that form, not from broker scopes (T97 — Accept source = "store" with store and id in a box spec's grant #2656)
    • scripts/session-e2e.sh: the seed of proof_bep_store_reference_end_to_end writes source = "store", store = "keychain" and id, and the # Interim spelling: comment goes
    • cargo nextest run -p boxes a_store_grant_parses_store_and_id
  • review:
    • crates/minimal/src/cmd/box_spec.rs: render reads each store row from boxes::core::bep::store_references() of the source = "store" form, not from grant.scopes; its test builds the reference in that form (widened 2026-10-31, owner, T97 — Accept source = "store" with store and id in a box spec's grant #2656 noop)
    • cargo nextest run -p minimal box_spec_lists_store_references_with_their_authorities
  • create:
    • crates/minimal/src/cmd/boxes/create.rs: the tests of accept_store_references build store references as source = "store" with store and id (widened 2026-10-31, owner, T97 — Accept source = "store" with store and id in a box spec's grant #2656 noop)
    • cargo nextest run -p minimal store_reference_without_rule_is_refused_at_creation
    • cargo nextest run -p minimal store_rule_outside_egress_exits_3

Waits on:

Plan block
### T97 — Accept source = "store" with store and id in a box spec's grant
  slice: S13
  kind: task
  covers: BEP-032
  size: M
  est: 160 code, 240 tests
  executor: agent
  difficulty: needs care
  model: standard
  diagnostics: a store reference spelled with `source = "store"` and no `store` or `id` is refused with text that names the missing field
  observability: none: the parse runs inside `min` box creation, which logs no line for a grant
  layers:
    - grant:
      - crates/boxes/src/core/bep.rs: `GrantSource` accepts `source = "store"` with `store` and `id`, and `store_references()` reads store references from that form, not from broker `scopes` (#2656)
      - scripts/session-e2e.sh: the seed of `proof_bep_store_reference_end_to_end` writes `source = "store"`, `store = "keychain"` and `id`, and the `# Interim spelling:` comment goes
      test: cargo nextest run -p boxes a_store_grant_parses_store_and_id
    - review:
      - crates/minimal/src/cmd/box_spec.rs: `render` reads each store row from `boxes::core::bep::store_references()` of the `source = "store"` form, not from `grant.scopes`; its test builds the reference in that form (widened 2026-10-31, owner, #2656 noop)
      test: cargo nextest run -p minimal box_spec_lists_store_references_with_their_authorities
    - create:
      - crates/minimal/src/cmd/boxes/create.rs: the tests of `accept_store_references` build store references as `source = "store"` with `store` and `id` (widened 2026-10-31, owner, #2656 noop)
      test: cargo nextest run -p minimal store_reference_without_rule_is_refused_at_creation
      test: cargo nextest run -p minimal store_rule_outside_egress_exits_3
  produces: none
  consumes: none
  proof: A box spec that declares a store reference as source = "store" with store and id mints and redeems it, and `min box spec` lists it with its authorities.
  depends on:
    - blocked by #2294
    - blocked by #2257

Generated by Claude Code

Activity

  1. changed the title [-]GrantSource: accept source = "store" with store and id, and take store references out of broker scopes[/-] [+]T97 — Accept source = "store" with store and id in a box spec's grant[/+] on Oct 27, 2026
  2. added
    kind:taskA task the plan skill rendered; the body carries ## Task
    size:M200 to 500 net lines; one PR
    model:standardA standard model: work that needs care, or routine work that is large
    on Oct 27, 2026
  3. minimal-foundry commented on Oct 30, 2026

    @minimal-foundry
    Contributor

    Done. #2774 merged.

    branch agent/2656-accept-source-store-with-store-and-id-in-a-box-s · epic #1501 · PR #2774

    round outcome job
    1 pushed 39656640
    2 pushed 517ca48c
    3 pushed b173b93a
    4 pushed 919b9510
    5 pushed 250b70c5

    Updated 2026-10-31T07:55:07.220Z.

  4. added
    needs-humanAn agent handed off; a human must act, then clear this label. Set by defer and handoffs.
    on Oct 30, 2026
  5. removed
    needs-humanAn agent handed off; a human must act, then clear this label. Set by defer and handoffs.
    on Oct 31, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    kind:taskA task the plan skill rendered; the body carries ## Taskmodel:standardA standard model: work that needs care, or routine work that is largesize:M200 to 500 net lines; one PR

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions

      0