8000 T21 — Log out: delete the sign-in and refuse every reference to it · Issue #2278 · gominimal/minimal · GitHub
[go: up one dir, main page]

Skip to content

T21 — Log out: delete the sign-in and refuse every reference to it #2278

Closed

Description

@norrietaylor

Task

slice size difficulty model who estimated lines
Revoke a box or sign out M needs care standard an agent 440 (220 code, 220 tests)

After min auth logout, every running box's next GitHub request is refused, and signing in again revives none of them.

Covers:

  • BEP-044

Layers:

  • cli:
    • crates/minimal/src/cli.rs: min auth logout
    • crates/minimal/src/cmd/auth.rs: deletes the item, asks GitHub to revoke best effort, reports either outcome without failing
    • cargo nextest run -p minimal logout_revokes_at_github_best_effort
    • cargo nextest run -p minimal sign_in_after_logout_revives_no_earlier_reference
  • e2e:
    • scripts/session-e2e.sh: adds the case
    • ./scripts/session-e2e.sh bep_logout_refuses_every_reference_at_next_request

Waits on:

Plan block
### T21 — Log out: delete the sign-in and refuse every reference to it
  slice: S1
  kind: task
  covers: BEP-044
  size: M
  est: 220 code, 220 tests
  executor: agent
  difficulty: needs care
  model: standard
  diagnostics: `min auth logout` prints "Signed out of GitHub. Boxes created before now lose GitHub access at their next request." and, when GitHub cannot be reached, "GitHub did not confirm the sign-out; the sign-in is removed from this machine." on stderr, pinned by logout_revokes_at_github_best_effort
  observability: one info log line per logout naming the account and whether GitHub confirmed the revocation
  layers:
    - cli:
      - crates/minimal/src/cli.rs: `min auth logout`
      - crates/minimal/src/cmd/auth.rs: deletes the item, asks GitHub to revoke best effort, reports either outcome without failing
      test: cargo nextest run -p minimal logout_revokes_at_github_best_effort
      test: cargo nextest run -p minimal sign_in_after_logout_revives_no_earlier_reference
    - e2e:
      - scripts/session-e2e.sh: adds the case
      test: ./scripts/session-e2e.sh bep_logout_refuses_every_reference_at_next_request
  produces: none
  consumes: none
  proof: After `min auth logout`, every running box's next GitHub request is refused, and signing in again revives none of them.
  depends on:
    - blocked by #2276

Activity

  1. added
    kind:taskA task the plan skill rendered; the body carries ## Task
    size:M200 to 500 net lines; one PR
    model:standardA standard model: work that needs care, or routine work that is large
    on Oct 17, 2026
  2. minimal-foundry commented on Oct 24, 2026

    @minimal-foundry
    Contributor

    Done. #2512 merged.

    branch agent/2278-log-out-delete-the-sign-in-and-refuse-every-refe · epic #1501 · PR #2512

    round outcome job
    1 changed nothing: Noop. The two failed checks do not come from this pull request. cargo-deny fails on a new RustSec advisory ('Multiple timing variability issues in operations intended to be constant-time') against ecd 71409eaa
    2 pushed 0f83d38b
    3 pushed f6da7690

    Updated 2026-10-24T22:52:55.346Z.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    kind:taskA task the plan skill rendered; the body carries ## Taskmodel:standardA standard model: work that needs care, or routine work that is largesize:M200 to 500 net lines; one PR

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions

      0