Repository navigation
Expand file tree
/
Copy pathdex_test.go
More file actions
329 lines (302 loc) · 8.73 KB
/
Copy pathdex_test.go
File metadata and controls
329 lines (302 loc) · 8.73 KB
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
package dex
import (
"bytes"
"fmt"
"net/http"
"net/http/httptest"
"strings"
"testing"
"github.com/ghodss/yaml"
"github.com/stretchr/testify/assert"
// "github.com/argoproj/argo-cd/common"
"github.com/argoproj/argo-cd/v2/util/settings"
)
const invalidURL = ":://localhost/foo/bar"
var malformedDexConfig = `
valid:
yaml: valid
yaml:
valid
`
var goodDexConfig = `
connectors:
# GitHub example
- type: github
id: github
name: GitHub
config:
clientID: aabbccddeeff00112233
clientSecret: $dex.github.clientSecret
orgs:
- name: your-github-org
# GitHub enterprise example
- type: github
id: acme-github
name: Acme GitHub
config:
hostName: github.acme.com
clientID: abcdefghijklmnopqrst
clientSecret: $dex.acme.clientSecret
orgs:
- name: your-github-org
`
var customStaticClientDexConfig = `
connectors:
# GitHub example
- type: github
id: github
name: GitHub
config:
clientID: aabbccddeeff00112233
clientSecret: abcdefghijklmnopqrst\n\r
orgs:
- name: your-github-org
staticClients:
- id: argo-workflow
name: Argo Workflow
redirectURIs:
- https://argo/oauth2/callback
secret: $dex.acme.clientSecret
`
var badDexConfig = `
connectors:
# GitHub example
- type: github
id: github
name: GitHub
config: foo
# GitHub enterprise example
- type: github
id: acme-github
name: Acme GitHub
config:
hostName: github.acme.com
clientID: abcdefghijklmnopqrst
clientSecret: $dex.acme.clientSecret
orgs:
- name: your-github-org
`
var goodSecrets = map[string]string{
"dex.github.clientSecret": "foobar",
"dex.acme.clientSecret": "barfoo",
}
var goodSecretswithCRLF = map[string]string{
"dex.github.clientSecret": "foobar\n\r",
"dex.acme.clientSecret": "barfoo\n\r",
}
func Test_GenerateDexConfig(t *testing.T) {
t.Run("Empty settings", func(t *testing.T) {
s := settings.ArgoCDSettings{}
config, err := GenerateDexConfigYAML(&s)
assert.NoError(t, err)
assert.Nil(t, config)
})
t.Run("Invalid URL", func(t *testing.T) {
s := settings.ArgoCDSettings{
URL: invalidURL,
DexConfig: goodDexConfig,
}
config, err := GenerateDexConfigYAML(&s)
assert.Error(t, err)
assert.Nil(t, config)
})
t.Run("No URL set", func(t *testing.T) {
s := settings.ArgoCDSettings{
URL: "",
DexConfig: "invalidyaml",
}
config, err := GenerateDexConfigYAML(&s)
assert.NoError(t, err)
assert.Nil(t, config)
})
t.Run("Invalid YAML", func(t *testing.T) {
s := settings.ArgoCDSettings{
URL: "http://localhost",
DexConfig: "invalidyaml",
}
config, err := GenerateDexConfigYAML(&s)
assert.NoError(t, err)
assert.Nil(t, config)
})
t.Run("Valid YAML but incorrect Dex config", func(t *testing.T) {
s := settings.ArgoCDSettings{
URL: "http://localhost",
DexConfig: malformedDexConfig,
}
config, err := GenerateDexConfigYAML(&s)
assert.Error(t, err)
assert.Nil(t, config)
})
t.Run("Valid YAML but incorrect Dex config", func(t *testing.T) {
s := settings.ArgoCDSettings{
URL: "http://localhost",
DexConfig: badDexConfig,
}
config, err := GenerateDexConfigYAML(&s)
assert.Error(t, err)
assert.Nil(t, config)
})
t.Run("Valid YAML and correct Dex config", func(t *testing.T) {
s := settings.ArgoCDSettings{
URL: "http://localhost",
DexConfig: goodDexConfig,
}
config, err := GenerateDexConfigYAML(&s)
assert.NoError(t, err)
assert.NotNil(t, config)
})
t.Run("Secret dereference", func(t *testing.T) {
s := settings.ArgoCDSettings{
URL: "http://localhost",
DexConfig: goodDexConfig,
Secrets: goodSecrets,
}
config, err := GenerateDexConfigYAML(&s)
assert.NoError(t, err)
assert.NotNil(t, config)
var dexCfg map[string]interface{}
err = yaml.Unmarshal(config, &dexCfg)
if err != nil {
panic(err.Error())
}
connectors, ok := dexCfg["connectors"].([]interface{})
assert.True(t, ok)
for i, connectorsIf := range connectors {
config := connectorsIf.(map[string]interface{})["config"].(map[string]interface{})
if i == 0 {
assert.Equal(t, "foobar", config["clientSecret"])
} else if i == 1 {
assert.Equal(t, "barfoo", config["clientSecret"])
}
}
})
t.Run("Secret dereference with extra white space", func(t *testing.T) {
s := settings.ArgoCDSettings{
URL: "http://localhost",
DexConfig: goodDexConfig,
Secrets: goodSecretswithCRLF,
}
config, err := GenerateDexConfigYAML(&s)
assert.NoError(t, err)
assert.NotNil(t, config)
var dexCfg map[string]interface{}
err = yaml.Unmarshal(config, &dexCfg)
if err != nil {
panic(err.Error())
}
connectors, ok := dexCfg["connectors"].([]interface{})
assert.True(t, ok)
for i, connectorsIf := range connectors {
config := connectorsIf.(map[string]interface{})["config"].(map[string]interface{})
if i == 0 {
assert.Equal(t, "foobar", config["clientSecret"])
} else if i == 1 {
assert.Equal(t, "barfoo", config["clientSecret"])
}
}
})
t.Run("Redirect config", func(t *testing.T) {
types := []string{"oidc", "saml", "microsoft", "linkedin", "gitlab", "github", "bitbucket-cloud"}
for _, c := range types {
assert.True(t, needsRedirectURI(c))
}
assert.False(t, needsRedirectURI("invalid"))
})
t.Run("Custom static clients", func(t *testing.T) {
s := settings.ArgoCDSettings{
URL: "http://localhost",
DexConfig: customStaticClientDexConfig,
Secrets: goodSecretswithCRLF,
}
config, err := GenerateDexConfigYAML(&s)
assert.NoError(t, err)
assert.NotNil(t, config)
var dexCfg map[string]interface{}
err = yaml.Unmarshal(config, &dexCfg)
if err != nil {
panic(err.Error())
}
clients, ok := dexCfg["staticClients"].([]interface{})
assert.True(t, ok)
assert.Equal(t, 3, len(clients))
customClient := clients[2].(map[string]interface{})
assert.Equal(t, "argo-workflow", customClient["id"].(string))
assert.Equal(t, 1, len(customClient["redirectURIs"].([]interface{})))
})
t.Run("Custom static clients secret dereference with trailing CRLF", func(t *testing.T) {
s := settings.ArgoCDSettings{
URL: "http://localhost",
DexConfig: customStaticClientDexConfig,
Secrets: goodSecretswithCRLF,
}
config, err := GenerateDexConfigYAML(&s)
assert.NoError(t, err)
assert.NotNil(t, config)
var dexCfg map[string]interface{}
err = yaml.Unmarshal(config, &dexCfg)
if err != nil {
panic(err.Error())
}
clients, ok := dexCfg["staticClients"].([]interface{})
assert.True(t, ok)
assert.Equal(t, 3, len(clients))
customClient := clients[2].(map[string]interface{})
assert.Equal(t, "barfoo", customClient["secret"])
})
}
func Test_DexReverseProxy(t *testing.T) {
t.Run("Good case", func(t *testing.T) {
fakeDex := httptest.NewServer(http.HandlerFunc(func(rw http.ResponseWriter, req *http.Request) {
rw.WriteHeader(http.StatusOK)
}))
defer fakeDex.Close()
fmt.Printf("Fake Dex listening on %s\n", fakeDex.URL)
server := httptest.NewServer(http.HandlerFunc(NewDexHTTPReverseProxy(fakeDex.URL, "/")))
fmt.Printf("Fake API Server listening on %s\n", server.URL)
defer server.Close()
resp, err := http.Get(server.URL)
assert.NotNil(t, resp)
assert.NoError(t, err)
assert.Equal(t, http.StatusOK, resp.StatusCode)
fmt.Printf("%s\n", resp.Status)
})
t.Run("Bad case", func(t *testing.T) {
fakeDex := httptest.NewServer(http.HandlerFunc(func(rw http.ResponseWriter, req *http.Request) {
rw.WriteHeader(http.StatusInternalServerError)
}))
defer fakeDex.Close()
fmt.Printf("Fake Dex listening on %s\n", fakeDex.URL)
server := httptest.NewServer(http.HandlerFunc(NewDexHTTPReverseProxy(fakeDex.URL, "/")))
fmt.Printf("Fake API Server listening on %s\n", server.URL)
defer server.Close()
client := &http.Client{
CheckRedirect: func(req *http.Request, via []*http.Request) error {
return http.ErrUseLastResponse
}}
resp, err := client.Get(server.URL)
assert.NotNil(t, resp)
assert.NoError(t, err)
assert.Equal(t, http.StatusSeeOther, resp.StatusCode)
location, _ := resp.Location()
fmt.Printf("%s %s\n", resp.Status, location.RequestURI())
assert.True(t, strings.HasPrefix(location.RequestURI(), "/login?sso_error"))
})
t.Run("Invalid URL for Dex reverse proxy", func(t *testing.T) {
// Can't test for now, since it would call exit
t.Skip()
f := NewDexHTTPReverseProxy(invalidURL, "/")
assert.Nil(t, f)
})
t.Run("Round Tripper", func(t *testing.T) {
server := httptest.NewServer(http.HandlerFunc(func(rw http.ResponseWriter, req *http.Request) {
assert.Equal(t, "/", req.URL.String())
}))
defer server.Close()
rt := NewDexRewriteURLRoundTripper(server.URL, http.DefaultTransport)
assert.NotNil(t, rt)
req, err := http.NewRequest("GET", "/", bytes.NewBuffer([]byte("")))
assert.NoError(t, err)
_, err = rt.RoundTrip(req)
assert.NoError(t, err)
})
}