Repository navigation
Expand file tree
/
Copy pathrest_tests.rs
More file actions
1370 lines (1227 loc) · 48.9 KB
/
Copy pathrest_tests.rs
File metadata and controls
1370 lines (1227 loc) · 48.9 KB
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
819
820
821
822
823
824
825
826
827
828
829
830
831
832
833
834
835
836
837
838
839
840
841
842
843
844
845
846
847
848
849
850
851
852
853
854
855
856
857
858
859
860
861
862
863
864
865
866
867
868
869
870
871
872
873
874
875
876
877
878
879
880
881
882
883
884
885
886
887
888
889
890
891
892
893
894
895
896
897
898
899
900
901
902
903
904
905
906
907
908
909
910
911
912
913
914
915
916
917
918
919
920
921
922
923
924
925
926
927
928
929
930
931
932
933
934
935
936
937
938
939
940
941
942
943
944
945
946
947
948
949
950
951
952
953
954
955
956
957
958
959
960
961
962
963
964
965
966
967
968
969
970
971
972
973
974
975
976
977
978
979
980
981
982
983
984
985
986
987
988
989
990
991
992
993
994
995
996
997
998
999
1000
use super::{
backend_api_body_shape, flatten_authed_error, is_announcements_latest_path,
is_unmatched_route_404, key_bytes_from_string, parse_message_path, sanitize_client_version,
BackendApiError, BackendOAuthClient, BACKEND_API_BODY_SHAPE_MAX_BYTES,
};
use crate::api::product::{
product_identity_test_lock, reset_product_identity_for_test, set_product_identity,
ProductIdentity, DEFAULT_PRODUCT_IDENTITY, PRODUCT_IDENTITY_HEADER,
};
use axum::extract::State;
use axum::http::HeaderMap;
use axum::routing::{get, post};
use axum::{Json, Router};
use base64::engine::general_purpose::{STANDARD, URL_SAFE_NO_PAD};
use base64::Engine;
use reqwest::Method;
use serde_json::{json, Value};
use std::sync::{Arc, Mutex};
use tokio::net::TcpListener;
#[test]
fn decodes_base64url_no_pad() {
// A 32-byte key that, when base64url-encoded, contains both `-` and `_`.
let raw = [
0xff_u8, 0xfb, 0xef, 0x00, 0x11, 0x22, 0x33, 0x44, 0x55, 0x66, 0x77, 0x88, 0x99, 0xaa,
0xbb, 0xcc, 0xdd, 0xee, 0xff, 0x01, 0x02, 0x03, 0x04, 0x05, 0x06, 0x07, 0x08, 0x09, 0x0a,
0x0b, 0x0c, 0x0d,
];
let url_key = URL_SAFE_NO_PAD.encode(raw);
assert!(url_key.contains('-') || url_key.contains('_'));
let decoded = key_bytes_from_string(&url_key).unwrap();
assert_eq!(decoded, raw);
}
#[test]
fn decodes_standard_base64() {
let raw = [0x41_u8; 32];
let std_key = STANDARD.encode(raw);
let decoded = key_bytes_from_string(&std_key).unwrap();
assert_eq!(decoded, raw);
}
#[test]
fn decodes_raw_32_byte_key() {
let raw = "abcdefghijklmnopqrstuvwxyz012345";
assert_eq!(raw.len(), 32);
let decoded = key_bytes_from_string(raw).unwrap();
assert_eq!(decoded, raw.as_bytes());
}
#[test]
fn trims_whitespace() {
let raw = [0x42_u8; 32];
let url_key = format!(" {}\n", URL_SAFE_NO_PAD.encode(raw));
let decoded = key_bytes_from_string(&url_key).unwrap();
assert_eq!(decoded, raw);
}
#[test]
fn rejects_wrong_length() {
let err = key_bytes_from_string("tooshort").unwrap_err();
assert!(err.to_string().contains("must decode to 32 raw bytes"));
}
use super::user_id_from_profile_payload;
#[test]
fn extracts_id_from_root() {
let payload1 = json!({ "id": "123" });
let payload2 = json!({ "_id": "456" });
let payload3 = json!({ "userId": "789" });
assert_eq!(user_id_from_profile_payload(&payload1).unwrap(), "123");
assert_eq!(user_id_from_profile_payload(&payload2).unwrap(), "456");
assert_eq!(user_id_from_profile_payload(&payload3).unwrap(), "789");
}
#[test]
fn extracts_id_from_data_nested() {
let payload = json!({
"data": { "id": "abc" }
});
assert_eq!(user_id_from_profile_payload(&payload).unwrap(), "abc");
}
#[test]
fn extracts_id_from_user_nested() {
let payload = json!({
"user": { "id": "def" }
});
assert_eq!(user_id_from_profile_payload(&payload).unwrap(), "def");
}
#[test]
fn extracts_id_from_data_user_nested() {
let payload = json!({
"data": {
"user": { "userId": "ghi" }
}
});
assert_eq!(user_id_from_profile_payload(&payload).unwrap(), "ghi");
}
#[test]
fn ignores_whitespace_only_ids() {
let payload = json!({
"data": {
"id": " ",
"_id": "real_id"
}
});
assert_eq!(user_id_from_profile_payload(&payload).unwrap(), "real_id");
}
#[test]
fn trims_extracted_ids() {
let payload = json!({
"id": " padded_id "
});
assert_eq!(user_id_from_profile_payload(&payload).unwrap(), "padded_id");
}
#[test]
fn rejects_non_string_ids() {
let payload = json!({
"id": 123,
"_id": ["not_a_string"],
"userId": "valid_id"
});
assert_eq!(user_id_from_profile_payload(&payload).unwrap(), "valid_id");
}
#[test]
fn returns_none_for_missing_ids() {
let payload = json!({
"data": { "name": "alice" }
});
assert!(user_id_from_profile_payload(&payload).is_none());
}
#[test]
fn returns_none_for_non_object_payload() {
let payload = json!("just a string");
assert!(user_id_from_profile_payload(&payload).is_none());
}
#[test]
fn sanitize_client_version_strips_invalid_chars_and_clamps_length() {
let raw = format!(" 1.2.3 (desktop)+build!?{} ", "a".repeat(80));
let sanitized = sanitize_client_version(&raw).unwrap();
assert_eq!(sanitized, format!("1.2.3desktop+build{}", "a".repeat(46)));
assert_eq!(sanitized.len(), 64);
}
#[derive(Clone, Default)]
struct CapturedHeaders {
entries: Arc<Mutex<Vec<HeaderMap>>>,
}
impl CapturedHeaders {
fn push(&self, headers: &HeaderMap) {
self.entries.lock().unwrap().push(headers.clone());
}
fn take(&self) -> Vec<HeaderMap> {
self.entries.lock().unwrap().clone()
}
}
async fn spawn_header_capture_server() -> (String, CapturedHeaders) {
async fn capture_consume(
State(captured): State<CapturedHeaders>,
headers: HeaderMap,
) -> Json<Value> {
captured.push(&headers);
Json(json!({
"success": true,
"data": { "jwt": "mock-jwt-token" }
}))
}
async fn capture_probe(
State(captured): State<CapturedHeaders>,
headers: HeaderMap,
) -> Json<Value> {
captured.push(&headers);
Json(json!({ "ok": true }))
}
let captured = CapturedHeaders::default();
let app = Router::new()
.route("/auth/login-token/consume", post(capture_consume))
.route("/probe", get(capture_probe))
.with_state(captured.clone());
let listener = TcpListener::bind("127.0.0.1:0").await.unwrap();
let addr = listener.local_addr().unwrap();
tokio::spawn(async move {
axum::serve(listener, app).await.unwrap();
});
(format!("http://{addr}"), captured)
}
#[tokio::test]
async fn backend_client_sends_x_core_version_on_auth_requests() {
let (base_url, captured) = spawn_header_capture_server().await;
let client = BackendOAuthClient::new(&base_url).unwrap();
let jwt = client.consume_login_token("test-token").await.unwrap();
assert_eq!(jwt, "mock-jwt-token");
let headers = captured.take();
let request_headers = headers.last().unwrap();
let version = request_headers
.get("x-core-version")
.and_then(|value| value.to_str().ok())
.unwrap();
assert_eq!(
version,
sanitize_client_version(env!("CARGO_PKG_VERSION")).unwrap()
);
assert_eq!(
request_headers
.get("x-sdk-client")
.and_then(|value| value.to_str().ok()),
Some("tinyhumans-rust"),
"typed auth requests must be sent by the TinyHumans SDK transport"
);
}
#[tokio::test]
async fn authed_json_uses_sdk_transport_with_bearer_and_host_headers() {
let (base_url, captured) = spawn_header_capture_server().await;
let client = BackendOAuthClient::new(&base_url).unwrap();
let response = client
.authed_json("sdk-cutover-token", Method::GET, "/probe", None)
.await
.unwrap();
assert_eq!(response, json!({ "ok": true }));
let headers = captured.take();
let request_headers = headers.last().unwrap();
assert_eq!(
request_headers
.get("authorization")
.and_then(|value| value.to_str().ok()),
Some("Bearer sdk-cutover-token")
);
assert_eq!(
request_headers
.get("x-sdk-client")
.and_then(|value| value.to_str().ok()),
Some("tinyhumans-rust")
);
assert!(
request_headers.get("x-core-version").is_some(),
"OpenHuman host metadata must survive the SDK cutover"
);
}
#[tokio::test]
async fn authed_json_cannot_bypass_sdk_admin_exclusions() {
let client = BackendOAuthClient::new("http://127.0.0.1:9").unwrap();
for (method, path) in [(Method::POST, "/admin/announcements")] {
let err = client
.authed_json("token", method, path, None)
.await
.unwrap_err();
assert!(
err.chain().any(|source| {
let message = source.to_string();
message.contains("intentionally not exposed")
}),
"{path} must be rejected locally by the SDK: {err:#}"
);
}
}
#[tokio::test]
async fn backend_client_sends_x_tauri_version_when_env_set() {
// Serialize against any concurrent test that also touches this env var.
static ENV_LOCK: Mutex<()> = Mutex::new(());
let _guard = ENV_LOCK.lock().unwrap();
std::env::set_var("OPENHUMAN_TAURI_VERSION", "9.8.7-shell+test");
let (base_url, captured) = spawn_header_capture_server().await;
let client = BackendOAuthClient::new(&base_url).unwrap();
let url = client.url_for("/probe").unwrap();
let response = client.raw_client().get(url).send().await.unwrap();
assert!(response.status().is_success());
std::env::remove_var("OPENHUMAN_TAURI_VERSION");
let headers = captured.take();
let request_headers = headers.last().unwrap();
let tauri_version = request_headers
.get("x-tauri-version")
.and_then(|value| value.to_str().ok())
.unwrap();
assert_eq!(tauri_version, "9.8.7-shell+test");
// Core version still flows alongside the new tauri version header.
assert!(request_headers.get("x-core-version").is_some());
}
// Regression: OPENHUMAN-TAURI-8K / Sentry issue 7473650958.
// When config.api_url is a full LLM completions URL (e.g. /v1/chat/completions),
// Url::join used to produce wrong paths like /v1/chat/teams/me/usage instead of
// /teams/me/usage — BackendOAuthClient::new must strip the path to prevent this.
#[test]
fn new_strips_path_from_completions_url() {
let client = BackendOAuthClient::new("https://api.tinyhumans.ai/v1/chat/completions").unwrap();
let url = client.url_for("/teams/me/usage").unwrap();
assert_eq!(url.path(), "/teams/me/usage");
}
#[test]
fn new_strips_path_from_openai_style_url() {<
8
/div>
let client = BackendOAuthClient::new("https://api.openai.com/v1/chat/completions").unwrap();
let url = client.url_for("/teams/me/usage").unwrap();
assert_eq!(url.path(), "/teams/me/usage");
assert_eq!(url.host_str(), Some("api.openai.com"));
}
#[test]
fn new_works_with_bare_origin() {
let client = BackendOAuthClient::new("https://api.tinyhumans.ai").unwrap();
let url = client.url_for("/teams/me/usage").unwrap();
assert_eq!(url.path(), "/teams/me/usage");
}
#[test]
fn new_works_with_trailing_slash() {
let client = BackendOAuthClient::new("https://api.tinyhumans.ai/").unwrap();
let url = client.url_for("/teams/me/usage").unwrap();
assert_eq!(url.path(), "/teams/me/usage");
}
#[tokio::test]
async fn backend_raw_client_inherits_x_core_version_default_header() {
let (base_url, captured) = spawn_header_capture_server().await;
let client = BackendOAuthClient::new(&base_url).unwrap();
let url = client.url_for("/probe").unwrap();
let response = client.raw_client().get(url).send().await.unwrap();
assert!(response.status().is_success());
let headers = captured.take();
let request_headers = headers.last().unwrap();
let version = request_headers
.get("x-core-version")
.and_then(|value| value.to_str().ok())
.unwrap();
assert_eq!(
version,
sanitize_client_version(env!("CARGO_PKG_VERSION")).unwrap()
);
}
#[tokio::test]
async fn sdk_path_sends_the_default_product_identity() {
let _guard = product_identity_test_lock();
reset_product_identity_for_test();
let (base_url, captured) = spawn_header_capture_server().await;
let client = BackendOAuthClient::new(&base_url).unwrap();
client
.authed_json("session-token", Method::GET, "/probe", None)
.await
.unwrap();
let headers = captured.take();
let request_headers = headers.last().unwrap();
assert_eq!(
request_headers
.get(PRODUCT_IDENTITY_HEADER)
.and_then(|value| value.to_str().ok()),
Some(DEFAULT_PRODUCT_IDENTITY),
"a build that sets no product identity must still attribute itself"
);
}
#[tokio::test]
async fn raw_client_sends_the_product_identity_alongside_the_version_headers() {
// `raw_client()` bypasses the SDK entirely (multipart STT upload), so the
// identity has to ride on the transport rather than only on the SDK.
let _guard = product_identity_test_lock();
reset_product_identity_for_test();
let (base_url, captured) = spawn_header_capture_server().await;
let client = BackendOAuthClient::new(&base_url).unwrap();
let url = client.url_for("/probe").unwrap();
let response = client.raw_client().get(url).send().await.unwrap();
assert!(response.status().is_success());
let headers = captured.take();
let request_headers = headers.last().unwrap();
assert_eq!(
request_headers
.get(PRODUCT_IDENTITY_HEADER)
.and_then(|value| value.to_str().ok()),
Some(DEFAULT_PRODUCT_IDENTITY)
);
assert!(request_headers.get("x-core-version").is_some());
}
#[tokio::test]
async fn an_embedding_product_can_override_the_product_identity() {
let _guard = product_identity_test_lock();
reset_product_identity_for_test();
// The identity is read when the client is built, so an embedding product
// sets it during startup, before it constructs any backend client.
set_product_identity(ProductIdentity::new("opencompany").unwrap());
let (base_url, captured) = spawn_header_capture_server().await;
let client = BackendOAuthClient::new(&base_url).unwrap();
let sdk_result = client
.authed_json("session-token", Method::GET, "/probe", None)
.await;
let url = client.url_for("/probe").unwrap();
let raw_result = client.raw_client().get(url).send().await;
reset_product_identity_for_test();
sdk_result.unwrap();
assert!(raw_result.unwrap().status().is_success());
let headers = captured.take();
assert_eq!(
headers.len(),
2,
"both transports should have been observed"
);
for request_headers in headers {
assert_eq!(
request_headers
.get(PRODUCT_IDENTITY_HEADER)
.and_then(|value| value.to_str().ok()),
Some("opencompany")
);
}
}
#[tokio::test]
async fn authed_json_surfaces_message_not_found_on_404() {
let app = Router::new()
.route(
"/channels/telegram/messages/1103",
post(|| async { (axum::http::StatusCode::NOT_FOUND, "Not Found") }),
)
.route(
"/channels/discord/messages/abc",
post(|| async { (axum::http::StatusCode::NOT_FOUND, "Not Found") }),
);
let listener = TcpListener::bind("127.0.0.1:0").await.unwrap();
let addr = listener.local_addr().unwrap();
tokio::spawn(async move {
axum::serve(listener, app).await.unwrap();
});
let base_url = format!("http://{addr}");
let client = BackendOAuthClient::new(&base_url).unwrap();
// Telegram path — matches OPENHUMAN-TAURI-2Y shape.
let err = client
.authed_json(
"mock-jwt",
Method::POST,
"/channels/telegram/messages/1103",
None,
)
.await
.unwrap_err();
let typed = err.downcast_ref::<BackendApiError>().unwrap();
let BackendApiError::MessageNotFound {
provider,
message_id,
} = typed
else {
panic!("expected MessageNotFound, got {typed:?}");
};
assert_eq!(provider, "telegram");
assert_eq!(message_id, "1103");
// Discord path — proves the helper is provider-agnostic.
let err = client
.authed_json(
"mock-jwt",
Method::POST,
"/channels/discord/messages/abc",
None,
)
.await
.unwrap_err();
let typed = err.downcast_ref::<BackendApiError>().unwrap();
let BackendApiError::MessageNotFound {
provider,
message_id,
} = typed
else {
panic!("expected MessageNotFound, got {typed:?}");
};
assert_eq!(provider, "discord");
assert_eq!(message_id, "abc");
}
#[tokio::test]
async fn authed_json_surfaces_announcement_not_found_on_404() {
// TAURI-RUST-HW0 / TAURI-RUST-KHX: 404 on `/announcements/latest` must
// surface a typed `BackendApiError::AnnouncementNotFound` (so the caller
// can degrade to `null`) instead of a generic non-2xx error.
let app = Router::new().route(
"/announcements/latest",
get(|| async { (axum::http::StatusCode::NOT_FOUND, "Not Found") }),
);
let listener = TcpListener::bind("127.0.0.1:0").await.unwrap();
let addr = listener.local_addr().unwrap();
tokio::spawn(async move {
axum::serve(listener, app).await.unwrap();
});
let base_url = format!("http://{addr}");
let client = BackendOAuthClient::new(&base_url).unwrap();
let err = client
.authed_json("mock-jwt", Method::GET, "/announcements/latest", None)
.await
.unwrap_err();
let typed = err.downcast_ref::<BackendApiError>().unwrap();
assert!(matches!(typed, BackendApiError::AnnouncementNotFound));
}
#[tokio::test]
async fn authed_json_only_classifies_get_announcements_latest_as_not_found() {
// Defense-in-depth: a 404 on a *different* path must not be misclassified
// as AnnouncementNotFound just because it shares a prefix/suffix.
let app = Router::new().route(
"/announcements/latest/extra",
get(|| async { (axum::http::StatusCode::NOT_FOUND, "Not Found") }),
);
let listener = TcpListener::bind("127.0.0.1:0").await.unwrap();
let addr = listener.local_addr().unwrap();
tokio::spawn(async move {
axum::serve(listener, app).await.unwrap();
});
let base_url = format!("http://{addr}");
let client = BackendOAuthClient::new(&base_url).unwrap();
let err = client
.authed_json("mock-jwt", Method::GET, "/announcements/latest/extra", None)
.await
.unwrap_err();
assert!(err.downcast_ref::<BackendApiError>().is_none());
}
#[tokio::test]
async fn authed_json_surfaces_announcement_not_found_with_base_path_prefix() {
// OPENHUMAN-TAURI-R7-style regression: a BACKEND_URL/path override that
// makes the resolved path `/api/v1/announcements/latest` must still
// classify as AnnouncementNotFound, not fall through to a generic error.
let app = Router::new().route(
"/api/v1/announcements/latest",
get(|| async { (axum::http::StatusCode::NOT_FOUND, "Not Found") }),
);
let listener = TcpListener::bind("127.0.0.1:0").await.unwrap();
let addr = listener.local_addr().unwrap();
tokio::spawn(async move {
axum::serve(listener, app).await.unwrap();
});
let base_url = format!("http://{addr}");
let client = BackendOAuthClient::new(&base_url).unwrap();
let err = client
.authed_json(
"mock-jwt",
Method::GET,
"/api/v1/announcements/latest",
None,
)
.await
.unwrap_err();
let typed = err.downcast_ref::<BackendApiError>().unwrap();
assert!(matches!(typed, BackendApiError::AnnouncementNotFound));
}
#[tokio::test]
async fn authed_json_surfaces_unauthorized_on_401() {
// OPENHUMAN-TAURI-4K8: 401 on any authed backend endpoint must surface a
// typed `BackendApiError::Unauthorized` and NOT funnel into `report_error`.
// The mascot TTS path (`/openai/v1/audio/speech`) was the loudest reporter,
// but the same shape fires on every authed endpoint once a session lapses,
// so we cover two different paths/methods to prove the suppression is
// status-driven, not path-keyed.
let app = Router::new()
.route(
"/openai/v1/audio/speech",
post(|| async { (axum::http::StatusCode::UNAUTHORIZED, "Unauthorized") }),
)
.route(
"/referral/stats",
get(|| async { (axum::http::StatusCode::UNAUTHORIZED, "Unauthorized") }),
);
let listener = TcpListener::bind("127.0.0.1:0").await.unwrap();
let addr = listener.local_addr().unwrap();
tokio::spawn(async move {
axum::serve(listener, app).await.unwrap();
});
let base_url = format!("http://{addr}");
let client = BackendOAuthClient::new(&base_url).unwrap();
// Mascot TTS path — the original reporter.
let err = client
.authed_json(
"mock-jwt",
Method::POST,
"/openai/v1/audio/speech",
Some(json!({ "text": "hello" })),
)
.await
.unwrap_err();
let typed = err.downcast_ref::<BackendApiError>().unwrap();
let BackendApiError::Unauthorized { method, path } = typed else {
panic!("expected Unauthorized, got {typed:?}");
};
assert_eq!(method, "POST");
assert_eq!(path, "/openai/v1/audio/speech");
// Generic GET on a non-TTS path — proves the suppression is per-status,
// not per-path. (Same root cause: expired/revoked backend session.)
let err = client
.authed_json("mock-jwt", Method::GET, "/referral/stats", None)
.await
.unwrap_err();
let typed = err.downcast_ref::<BackendApiError>().unwrap();
let BackendApiError::Unauthorized { method, path } = typed else {
panic!("expected Unauthorized, got {typed:?}");
};
assert_eq!(method, "GET");
assert_eq!(path, "/referral/stats");
}
#[test]
fn backend_api_body_shape_emits_safe_keys_not_values() {
// PII guard (Codex P1 on #4058): the body SHAPE must expose only schema-like
// top-level key NAMES and NEVER the values — a non-2xx body can carry emails /
// tokens / profile JSON that would otherwise leak to unscrubbed daily logs.
let body = r#"{"error":"not found","email":"jo@example.com","token":"sk-secret"}"#;
let shape = backend_api_body_shape(body);
assert_eq!(shape, "object(keys=3,safe=[email,error,token],redacted=0)");
assert!(!shape.contains("jo@example.com"), "value leaked: {shape}");
assert!(!shape.contains("sk-secret"), "value leaked: {shape}");
assert!(!shape.contains("not found"), "value leaked: {shape}");
}
#[test]
fn backend_api_body_shape_redacts_pii_and_nonidentifier_keys() {
// CodeRabbit Major on #4058: key NAMES are response-controlled too. A foreign
// backend can put an email / free text / unicode in the KEY position; those
// must be counted as `redacted`, never echoed.
let body = r#"{"jo@example.com":1,"a b":2,"naïve":3,"error":4}"#;
let shape = backend_api_body_shape(body);
// Only the schema-like `error` survives; the other three are redacted.
assert_eq!(shape, "object(keys=4,safe=[error],redacted=3)");
assert!(!shape.contains("jo@example.com"), "PII key leaked: {shape}");
assert!(!shape.contains("naïve"), "non-ascii key leaked: {shape}");
assert!(!shape.contains("a b"), "free-text key leaked: {shape}");
}
#[test]
fn backend_api_body_shape_classifies_non_object_bodies() {
assert_eq!(backend_api_body_shape(""), "empty");
assert_eq!(backend_api_body_shape(" "), "empty");
assert_eq!(
backend_api_body_shape("Cannot GET /teams/me/usage"),
"non_json"
);
assert_eq!(backend_api_body_shape("<html>404</html>"), "non_json");
assert_eq!(backend_api_body_shape("[1,2,3]"), "array");
assert_eq!(backend_api_body_shape("42"), "scalar");
}
#[test]
fn backend_api_body_shape_bounds_long_safe_key_list() {
// The `safe=[…]` list is truncated at BACKEND_API_BODY_SHAPE_MAX_BYTES = 120.
// Surviving keys are ASCII identifiers (non-ASCII keys are redacted upstream),
// so build many ASCII keys to overflow the cap and assert the truncation
// CONTRACT: bounded, ellipsis-terminated, and not carrying the last key.
let mut obj = serde_json::Map::new();
for i in 0..30 {
obj.insert(format!("field{i:02}"), json!(1)); // 30 × "fieldNN" (7 bytes) ≫ 120
}
let body = serde_json::to_string(&Value::Object(obj)).unwrap();
let shape = backend_api_body_shape(&body);
let keys = shape
.strip_prefix("object(keys=30,safe=[")
.and_then(|s| s.strip_suffix("],redacted=0)"))
.unwrap_or_else(|| panic!("unexpected shape: {shape}"));
assert!(
keys.len() <= BACKEND_API_BODY_SHAPE_MAX_BYTES,
"safe list exceeds cap ({} > {BACKEND_API_BODY_SHAPE_MAX_BYTES}): {keys}",
keys.len()
);
assert!(keys.ends_with('…'), "expected ellipsis-terminated: {keys}");
assert!(
!keys.contains("field29"),
"last key should be truncated away: {keys}"
);
}
#[tokio::test]
async fn authed_json_reports_non_channel_404_still_propagates() {
// TAURI-RUST-8C: a GET 404 on a non-channel path (e.g. `/teams/me/usage`)
// falls through to `report_error` (not a typed/suppressed state) — it must
// still return an Err (no suppression) and not a typed `BackendApiError`.
let app = Router::new().route(
"/teams/me/usage",
get(|| async {
(
axum::http::StatusCode::NOT_FOUND,
r#"{"message":"Not Found"}"#,
)
}),
);
let listener = TcpListener::bind("127.0.0.1:0").await.unwrap();
let addr = listener.local_addr().unwrap();
tokio::spawn(async move {
axum::serve(listener, app).await.unwrap();
});
let base_url = format!("http://{addr}");
let client = BackendOAuthClient::new(&base_url).unwrap();
let err = client
.authed_json("mock-jwt", Method::GET, "/teams/me/usage", None)
.await
.unwrap_err();
assert!(err.downcast_ref::<BackendApiError>().is_none());
let msg = format!("{err:#}");
assert!(msg.contains("404"), "error should carry the status: {msg}");
assert!(
msg.contains("/teams/me/usage"),
"error should carry the path: {msg}"
);
}
#[test]
fn flatten_authed_error_maps_unauthorized_to_session_expired_sentinel() {
// #3297: the typed `Unauthorized` (expected session-lapse 401) must flatten
// onto a string that the JSON-RPC session-expiry classifiers recognise, so
// it is suppressed from Sentry (TAURI-RUST-8WY / 8WZ) instead of leaking.
let err = anyhow::Error::new(BackendApiError::Unauthorized {
method: "GET".to_string(),
path: "/teams/me/usage".to_string(),
});
let flat = flatten_authed_error(err);
// Carries the SESSION_EXPIRED sentinel + preserves method/path for logs.
assert!(
flat.contains("SESSION_EXPIRED"),
"expected sentinel, got: {flat}"
);
assert!(flat.contains("GET"), "method preserved: {flat}");
assert!(flat.contains("/teams/me/usage"), "path preserved: {flat}");
// Contract cross-check: the flattened string MUST classify as session
// expiry. This couples the mapping to the actual classifier — if either the
// sentinel or the classifier drifts, this fails instead of silently leaking.
assert!(
crate::core::observability::is_session_expired_message(&flat),
"flattened Unauthorized must classify as session expiry: {flat}"
);
}
#[test]
fn flatten_authed_error_preserves_non_unauthorized_chain() {
// A non-Unauthorized failure (e.g. a transient network/timeout error) keeps
// its full `{e:#}` anyhow chain and must NOT be demoted to session expiry —
// genuine failures still reach Sentry.
let err = anyhow::anyhow!("connect timeout").context("backend request GET /teams/me/usage");
let flat = flatten_authed_error(err);
assert!(!flat.contains("SESSION_EXPIRED"), "must not map: {flat}");
assert!(flat.contains("connect timeout"), "cause preserved: {flat}");
assert!(
!crate::core::observability::is_session_expired_message(&flat),
"non-auth error must NOT classify as session expiry: {flat}"
);
}
#[test]
fn flatten_authed_error_does_not_swallow_message_not_found() {
// `MessageNotFound` is a different expected state handled by its own callers
// (channel streaming/delete paths downcast it); it must not be collapsed
// into the session-expiry sentinel here.
let err = anyhow::Error::new(BackendApiError::MessageNotFound {
provider: "telegram".to_string(),
message_id: "1103".to_string(),
});
let flat = flatten_authed_error(err);
assert!(!flat.contains("SESSION_EXPIRED"), "must not map: {flat}");
assert!(
flat.contains("message not found"),
"display preserved: {flat}"
);
}
#[test]
fn flatten_authed_error_does_not_swallow_announcement_not_found() {
// `announcements::ops::get_latest_announcement` intercepts
// `AnnouncementNotFound` before it ever reaches `flatten_authed_error`, but
// this is defense-in-depth: if a future caller skips that interception,
// `flatten_authed_error` must still preserve the typed state's Display
// text rather than collapsing it into the session-expiry sentinel.
let err = anyhow::Error::new(BackendApiError::AnnouncementNotFound);
let flat = flatten_authed_error(err);
assert!(!flat.contains("SESSION_EXPIRED"), "must not map: {flat}");
assert!(
flat.contains("no announcement available"),
"display preserved: {flat}"
);
}
#[tokio::test]
async fn authed_json_403_is_not_demoted_to_unauthorized() {
// 403 (Forbidden) is a genuine authorization/permission problem — the
// token authenticated but lacked scope. That IS a code/config bug we
// want to keep in Sentry; only 401 (token rejected as a whole) maps
// to the expected-state `Unauthorized` variant.
let app = Router::new().route(
"/openai/v1/audio/speech",
post(|| async { (axum::http::StatusCode::FORBIDDEN, "Forbidden") }),
);
let listener = TcpListener::bind("127.0.0.1:0").await.unwrap();
let addr = listener.local_addr().unwrap();
tokio::spawn(async move {
axum::serve(listener, app).await.unwrap();
});
let base_url = format!("http://{addr}");
let client = BackendOAuthClient::new(&base_url).unwrap();
let err = client
.authed_json("mock-jwt", Method::POST, "/openai/v1/audio/speech", None)
.await
.unwrap_err();
assert!(
err.downcast_ref::<BackendApiError>().is_none(),
"403 must not be classified as Unauthorized"
);
}
#[tokio::test]
async fn authed_json_404_outside_messages_path_still_reports() {
// 404 on a non-`/channels/<provider>/messages/<id>` path should NOT be
// demoted to MessageNotFound — it's a real backend bug or routing
// mistake and must keep its Sentry signal.
let app = Router::new().route(
"/auth/profile",
get(|| async { (axum::http::StatusCode::NOT_FOUND, "Not Found") }),
);
let listener = TcpListener::bind("127.0.0.1:0").await.unwrap();
let addr = listener.local_addr().unwrap();
tokio::spawn(async move {
axum::serve(listener, app).await.unwrap();
});
let base_url = format!("http://{addr}");
let client = BackendOAuthClient::new(&base_url).unwrap();
let err = client
.authed_json("mock-jwt", Method::GET, "/auth/profile", None)
.await
.unwrap_err();
assert!(
err.downcast_ref::<BackendApiError>().is_none(),
"non-channel-message 404 must not be classified as MessageNotFound"
);
}
// ── parse_message_path unit tests (TAURI-R7 regression guard) ───────────────
#[test]
fn parse_message_path_canonical_form() {
assert_eq!(
parse_message_path("/channels/telegram/messages/1103"),
Some(("telegram", "1103"))
);
}
#[test]
fn parse_message_path_discord_provider() {
assert_eq!(
parse_message_path("/channels/discord/messages/abc"),
Some(("discord", "abc"))
);
}
#[test]
fn parse_message_path_base_path_prefix() {
// TAURI-R7 root cause: BACKEND_URL with a path prefix adds segments,
// breaking the strict 4-segment check. The sliding window must handle it.
assert_eq!(
parse_message_path("/api/v1/channels/telegram/messages/1103"),
Some(("telegram", "1103"))
);
}
#[test]
fn parse_message_path_double_prefix() {
assert_eq!(
parse_message_path("/v2/api/channels/discord/messages/abc"),
Some(("discord", "abc"))
);
}
#[test]
fn parse_message_path_trailing_slash() {
assert_eq!(
parse_message_path("/channels/telegram/messages/1103/"),
Some(("telegram", "1103"))
);
}
#[test]
fn parse_message_path_percent_encoded_slug() {
// Channel slugs with percent-encoded characters must pass through verbatim.
assert_eq!(
parse_message_path("/channels/telegram%3Abot/messages/1103"),
Some(("telegram%3Abot", "1103"))
);
}
#[test]
fn parse_message_path_non_message_path_returns_none() {
assert_eq!(parse_message_path("/channels/telegram/typing"), None);
assert_eq!(parse_message_path("/channels/telegram"), None);
assert_eq!(parse_message_path("/auth/profile"), None);
assert_eq!(parse_message_path("/"), None);
assert_eq!(parse_message_path(""), None);
}
#[test]
fn is_announcements_latest_path_matches_canonical_form() {
assert!(is_announcements_latest_path("/announcements/latest"));
}
#[test]
fn is_announcements_latest_path_tolerates_base_path_prefix() {
// Same OPENHUMAN-TAURI-R7 reasoning as parse_message_path: a BACKEND_URL
// override with a path prefix must not defeat the 404 classification.
assert!(is_announcements_latest_path("/api/v1/announcements/latest"));
assert!(is_announcements_latest_path("/v2/api/announcements/latest"));
}
#[test]
fn is_announcements_latest_path_trailing_slash() {
assert!(is_announcements_latest_path("/announcements/latest/"));
}
#[test]
fn is_announcements_latest_path_rejects_other_paths() {
assert!(!is_announcements_latest_path("/announcements/latest/extra"));
assert!(!is_announcements_latest_path("/announcements"));
assert!(!is_announcements_latest_path("/latest"));
assert!(!is_announcements_latest_path("/auth/profile"));
assert!(!is_announcements_latest_path("/"));
assert!(!is_announcements_latest_path(""));
}
// ── authed_json defense-in-depth: PATCH 404 with base-path prefix ───────────
#[tokio::test]
async fn authed_json_patch_404_with_base_path_prefix_does_not_report() {
// Regression for TAURI-R7: if the resolved URL has a base-path prefix,
// authed_json must still suppress the 404 — NOT call report_error.
//
// Since BackendOAuthClient strips the base path in `new()`, the path
// passed to authed_json is always joined against the stripped base. We
// verify that a PATCH 404 returns an error without panicking and that it
// is not classified as a code bug (no Sentry event).
//
// #5230: the classification is `ChannelEditUnsupported`, NOT
// `MessageNotFound`. The backend implements no `PATCH
// /channels/:channel/messages/:messageId`, so this 404 is route absence.
// Reporting it as a missing *message* made `bus.rs` forget a message id it
// still owned, orphaning the streaming draft and the "💭 Thinking:" bubble.
let app = axum::Router::new().route(
"/channels/telegram/messages/9999",
axum::routing::any(|| async { (axum::http::StatusCode::NOT_FOUND, "Not Found") }),
You can’t perform that action at this time.